[PATCH] D42833: [LICM] update BlockColors after splitting predecessors

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 08:23:36 PST 2018

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.


Comment at: lib/Transforms/Scalar/LICM.cpp:862-865
+  // FIXME: it's not impossible to split LandingPad blocks, but if BlockColors
+  // already exist it require updating BlockColors for all offspring blocks
+  // accordingly. By skipping such corner case, we can make updating BlockColors
+  // after splitting predecessor fairly simple.
I'd remove the FIXME and replace LandingPad with EHPad


More information about the llvm-commits mailing list