[PATCH] D43188: [ELF] Make .eh_frame relro if one of the inputs is SHF_WRITE

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 07:12:52 PST 2018


joerg added a comment.

Please stop adding complexity to doctor around the symptoms. There are two real fixes here and this change doesn't help with either:
(1) Emit cross-section pointers as indirect. This increases the binary size, but otherwise ensures that any linker can create read-only .eh_frame on MIPS.
(2) Teach lld on MIPS to properly reassemble the DWARF instructions, similar to what GNU ld can do. The latter is a bit stupid and needs a good kick to work properly, but this is the correct approach forward.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43188





More information about the llvm-commits mailing list