[PATCH] D43119: [zorg] Add AArch32 global-isel bots

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:324
+                      runTestSuite=True,
+                      testsuite_flags=['--cppflags', '-O0 -mllvm -global-isel -mllvm -global-isel-abort=0',
+                                       '--threads=64', '--build-threads=64'],
----------------
maxim-kuvyrkov wrote:
> rovka wrote:
> > Well, technically my patch was only for the ARMv7 part. I'm not sure how this one is supposed to work. What makes this AArch32? If we run on an armv8 machine, won't it by default use AArch64?
> Docker containers are started on ARMv8 machine under "linux32" personality and with armhf ubuntu rootfs.  This makes LLVM detect bot as armv8l-linux-gnueabihf .
Ah, ok. I'd like it better if we set the triple on the command line, since that would make things more explicit. Alternatively, it might be a good idea to build only the ARM target, and not AArch64, to make sure things blow up if this ends up on a misconfigured container in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D43119