[PATCH] D43152: [DWARFv5] Turn an assert into a diagnostic.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Not sure what you mean by "a non-syscall diagnostic"? (there's StringError if you want to just put a string rather than an error code)

What is it that's undesirable about the error handling you've implemented here? Given that there's a similar error path nearby, that seems like a reasonable (or at least consistent) approach... but I've not looked at this area of the code in detail to see if there's something particularly undesirable about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D43152