[PATCH] D43080: Adding Msan support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: test/msan/tzset.cc:2
 // RUN: %clangxx_msan -O0 %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
devnexen wrote:
> krytarowski wrote:
> > devnexen wrote:
> > > krytarowski wrote:
> > > > devnexen wrote:
> > > > > krytarowski wrote:
> > > > > > devnexen wrote:
> > > > > > > krytarowski wrote:
> > > > > > > > devnexen wrote:
> > > > > > > > > krytarowski wrote:
> > > > > > > > > > Why unsupported?
> > > > > > > > > Those are not set in FreeBSD thus giving segfaults.
> > > > > > > > What does it mean in detail? tzset() under MSan emits SIGSEGV?
> > > > > > > > 
> > > > > > > > Broken tests should be marked as XFAIL.
> > > > > > > Yes indeed the sanitizer emits the message.
> > > > > > I have a pending patch for tzset() in D42050.. maybe it helps?
> > > > > Seems it does fix it indeed. Either I still put it as UNSUPPORTED/XFAIL or making it as SUPPORTED waiting your patch going through first.
> > > > Please help me to upstream it!
> > > Done hopefully it will go through quickly.
> > Thanks! There are few mores I need help. Would you like to help me with D40714? It fails for some reason on Linux - I don't have this OS handy to investigate.
> > 
> > D41013 - here we might share a common FreeBSD & NetBSD solution to this test.
> About D40714 I ve tried and indeed it fails, maybe the solution is to intercept atexit on everything but Linux (maybe it works ok on Android ?).
There is very similar code for TSan and it works.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080