[llvm] r324554 - AMDGPU: Fix incorrect reordering when inline asm defines LDS address

[Kai Wasserbäch via llvm-commits]

Hey Michel,
Michel Dänzer via llvm-commits wrote on 09.02.2018 11:17:
> On 2018-02-08 07:33 PM, Matt Arsenault wrote:
>>> On Feb 8, 2018, at 12:35, Michel Dänzer via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>> On 2018-02-08 02:56 AM, Matt Arsenault via llvm-commits wrote:
>>>> Author: arsenm
>>>> Date: Wed Feb  7 17:56:14 2018
>>>> New Revision: 324554
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=324554&view=rev
>>>> Log:
>>>> AMDGPU: Fix incorrect reordering when inline asm defines LDS address
>>>>
>>>> Defs of operands outside of the instruction's explicit defs need
>>>> to be checked.
>>>
>>> This change broke a bunch of
>>> spec at arb_gpu_shader_int64@execution at built-in-functions piglit tests with
>>> radeonsi. I'm attaching good and bad code for one of them.
>>
>> I think this should be fixed by https://reviews.llvm.org/D42647
> 
> Unfortunately, that doesn't apply to current trunk, so I can't confirm
> right now.

if I didn't botch up too badly, the attached patch should work (the build for
amd64 was successful and the build for i386 is still running, so that is
promising at least... ;-) I haven't exercised this build yet though – clean LLVM
builds always take a while for me). The patch applies cleanly on top of r324770
and should also apply on top of SVN HEAD.

NOTE: I removed the changes to smrd.ll from the patch, since the meat of the
patch segment doesn't seem to be around any longer (or at least not in that file).

Cheers,
Kai

P.S.: If you want, I can upload the resulting Debian packages for you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42647-AMDGPU-Track-physreg-uses-in-SILoadStoreOptimizer.patch
Type: text/x-patch
Size: 3973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180210/e35ca038/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180210/e35ca038/attachment.sig>