[PATCH] D43155: [asan] Add "arm64" into the list of 64-bit architectures

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 22:17:18 PST 2018


kubamracek created this revision.
kubamracek added reviewers: dvyukov, delcypher, filcab, eugenis, george.karpenkov.
kubamracek added a project: Sanitizers.
Herald added subscribers: Sanitizers, kristof.beyls, mgorny.

It looks like `get_bits_for_arch` doesn't recognize "arm64" as a 64-bit architecture, and it actually matches the "arm" regexp, which marks it as 32-bit. Let's fix that by matching the 64-bit list first and addin "arm64" into the list.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43155

Files:
  test/asan/CMakeLists.txt


Index: test/asan/CMakeLists.txt
===================================================================
--- test/asan/CMakeLists.txt
+++ test/asan/CMakeLists.txt
@@ -18,10 +18,10 @@
 endif()
 
 macro(get_bits_for_arch arch bits)
-  if (${arch} MATCHES "i386|arm|mips|mipsel")
-    set(${bits} 32)
-  elseif (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|mips64|mips64el|s390x")
+  if (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|arm64|mips64|mips64el|s390x")
     set(${bits} 64)
+  elseif (${arch} MATCHES "i386|arm|mips|mipsel")
+    set(${bits} 32)
   else()
     message(FATAL_ERROR "Unknown target architecture: ${arch}")
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43155.133740.patch
Type: text/x-patch
Size: 652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180210/4e07bed9/attachment.bin>


More information about the llvm-commits mailing list