[PATCH] D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D42937#1004102, @wolfgangp wrote:

> In https://reviews.llvm.org/D42937#1003956, @dblaikie wrote:
>
> > Curious combination of tests - some assembly, some IR. I think I made the existing test cases all checked in binaries.
> >
> > Perhaps we could come up with a uniform approach/strategy here? (& yeah, I'd probably separate the "testing DWP input" from "testing DWP output" rather than weaving one into the other)
>
>
> I admit I have a preference for assembly files over checked-in binaries. With checked-in binaries you'd probably have to check in the assembly source as well for reference, and then you have to keep them consistent.


Same here, which is why I keep doing it.
Hard to code-review or edit a binary file.  I don't think it costs that much to run llvm-mc on an assembler source, and the benefit in ease of understanding the test is huge.


https://reviews.llvm.org/D42937