[PATCH] D43028: Add DBG_VALUE support to the linear DAG scheduler

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a subscriber: debug-info.
vsk added a comment.

Thanks for working on this.



================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp:791
+      ArrayRef<SDDbgValue*> DVs = DAG->GetDbgValues(N);
+      for (unsigned i = 0, e = DVs.size(); i != e; ++i) {
+        if (DVs[i]->isInvalidated())
----------------
Nit: could you used a range-for loop here and run clang-format over the diff?


================
Comment at: test/CodeGen/Generic/linear-dbg-value.ll:29
+; CHECK: DBG_VALUE
+; CHECK-SAME: !14, !17,
+  %indvars.iv = phi i64 [ %indvars.iv.next, %for.body ], [ 0, %for.body.preheader ]
----------------
I'm not able to follow what's changed based on these check lines. Could you attach llc's pre-patch/post-patch output, so we can see how the output changes?


Repository:
  rL LLVM

https://reviews.llvm.org/D43028