[PATCH] D43097: [WebAssembly] Allow for the creation of user-defined custom sections

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 14:58:45 PST 2018


sunfish added a comment.

I think it's because writeBytes is defined to be passed data from an MCFragment's getContents(), which is a SmallVectorImpl<char>. That's the case here too, though the code that does the getContents() is a little separated from the writeBytes. Following @ncw's suggestion, I created a struct type, which not only avoids repeating the type name, but also makes the use of it cleaner than std::pair.


Repository:
  rL LLVM

https://reviews.llvm.org/D43097





More information about the llvm-commits mailing list