[PATCH] D43101: [WebAssebmly] Report undefined symbols correctly in objdump

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 13:33:23 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D43101#1003747, @ncw wrote:

> This looks good, maybe you spotted it could be improved when you saw I'd thoughtlessly copied the current llvm-objdump output for the new data/global symbol split!
>
> There will be conflicts with the symtab work, but not especially hard to resolve. Having said that, I think the conflicts and merge procedure would be rather simpler if the symtab stuff went in first (since it's a bigger thing to rebase and rejig overall).
>
> Edit: d'oh, you merged it literally as I was typing :(


I've already got your patches resolved and sitting on top of this.   I not sure how you feel about me taking them on, but I'm currently experimenting with them a little.  If you want to rebase you can, or I can keep working on my locally rebased version.   The lld-side I was thinking about is a lot more conflicting so I might land symtab before it: https://reviews.llvm.org/D43112


Repository:
  rL LLVM

https://reviews.llvm.org/D43101





More information about the llvm-commits mailing list