[PATCH] D42576: [test-suite] Add prototypes to functions in Olden and MiBench

[Dan Gohman via Phabricator via llvm-commits]

sunfish added a comment.

There is also an upside to not supporting unprototyped functions. Not only did people writing C in the distant past before prototypes not know what we know today about what it takes to have reasonably robust C code, but leaving C code unmaintained for decades is the opposite of what it takes to have reasonably robust C code, so such code is in double trouble. Obliging people who have unmaintained C codebases to either maintain them or forego using them on new platforms is a positive outcome. It's within reason to assign a variety of relative weights to that outcome, relative to the other outcomes.


Repository:
  rT test-suite

https://reviews.llvm.org/D42576