[PATCH] D43130: [ThinLTO] Teach ThinLTO about auto hide symbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM although I have a suggestion on where to move the new code.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:693
     } else {
       DEBUG(dbgs() << "ODR fixing up linkage for `" << GV.getName() << "` from "
                    << GV.getLinkage() << " to " << NewLinkage << "\n");
----------------
Suggest moving the new check down into this else, which is the only condition under which it could be true, to avoid unnecessary checking.


Repository:
  rL LLVM

https://reviews.llvm.org/D43130