[PATCH] D43129: [Utils] Salvage debug info from dead 'or' instructions

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1545
           for (auto *DII : DbgUsers)
-            applyOffset(DII, ConstInt->getSExtValue());
+            if (BI->getOpcode() == Instruction::Add)
+              applyOffset(DII, Val);
----------------
That codepath doesn't look like it's tested?


================
Comment at: lib/Transforms/Utils/Local.cpp:1548
+            else if (BI->getOpcode() == Instruction::Or)
+              applyOps(DII, {dwarf::DW_OP_constu, Val, dwarf::DW_OP_or});
+        }
----------------
Could any of the other cases be refactored to make use of this new helper, too?


Repository:
  rL LLVM

https://reviews.llvm.org/D43129