[PATCH] D40199: [dwarfdump] Fix spurious verification errors for DW_AT_location attributes

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere updated this revision to Diff 133637.
JDevlieghere marked 3 inline comments as done.
JDevlieghere retitled this revision from "llvm-dwarfdump --verify is incorrectly saying all DW_AT_location attributes with locations lists are invalid." to "[dwarfdump] Fix spurious verification errors for DW_AT_location attributes".
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.

Fixed Adrian's comments.

I also discovered that I was using this false positive to test the `dsymutil -verify` feature, so I had to fixing that test as well.


https://reviews.llvm.org/D40199

Files:
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/tools/dsymutil/Inputs/invalid.o
  llvm/test/tools/dsymutil/Inputs/invalid.s
  llvm/test/tools/dsymutil/X86/verify.test
  llvm/test/tools/llvm-dwarfdump/X86/debugloc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40199.133637.patch
Type: text/x-patch
Size: 5417 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180209/0e81a4bb/attachment.bin>