[PATCH] D41860: [CallSiteSplitting] Support splitting of blocks with instrs before call.

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml accepted this revision.
junbuml added a comment.
This revision is now accepted and ready to land.

LGTM, but I may want to hold it for sometime to let other reviewers take a chance to look at this as well.



================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:190
   BasicBlock *CallSiteBB = Instr->getParent();
-  if (Instr != CallSiteBB->getFirstNonPHIOrDbg())
-    return false;
+  // Allow splitting a call-site only when there the CodeSize cost of the
+  // instructions before the call is less then DuplicationThreshold. The
----------------
when there the CodeSize -> when the CodeSize 


https://reviews.llvm.org/D41860