[PATCH] D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:


> Index: ELF/LinkerScript.cpp
> ===================================================================
> --- ELF/LinkerScript.cpp
> +++ ELF/LinkerScript.cpp
> @@ -765,6 +765,13 @@
>  }
>  
>  static bool isAllSectionDescription(const OutputSection &Cmd) {
> +  // We do not want to remove sections that have custom address or align
> +  // expressions set even if them are empty. We keep them because still
> +  // want to be sure that any expressions can be evaluated and report
> +  // an error otherwise.


"because still" should probably be "because we".

LGTM with that.

Cheers,
Rafael