[PATCH] D43117: [zorg] Cleanup unnecessary options for ARM and AArch64 bots

[Maxim Kuvyrkov via Phabricator via llvm-commits]

maxim-kuvyrkov added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:248
                                         "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
-                                        "-DLLVM_LIT_ARGS='-sv -j2'",
                                         "-DLLVM_PARALLEL_LINK_JOBS=2"])},
 
----------------
rengolin wrote:
> You want to keep the -sv as that should very important information about the tests that failed.
"-sv" are default LLVM_LIT_ARGS set in CMakeLists.txt.


================
Comment at: buildbot/osuosl/master/config/builders.py:287
                       runTestSuite=True,
                       testsuite_flags=['--cppflags', '-mcpu=cortex-a57',
                                        '--threads=8', '--build-threads=8'],
----------------
rengolin wrote:
> You're not changing it for LNT, better to do that for both.
> 
> I'd also try mcup=native instead...
> You're not changing it for LNT, better to do that for both.

What do you mean?  There is no aarch64 LNT bot [yet].

> I'd also try mcup=native instead...

Yeah, I plan to switch bots (or add extra variants of bots) for -mcpu=native.  That's gonna be a future change.


================
Comment at: buildbot/osuosl/master/config/builders.py:326
                       runTestSuite=True,
-                      testsuite_flags=['--cppflags',
-                                       '-mcpu=cortex-a57 -O0 -mllvm -global-isel -mllvm -global-isel-abort=0',
+                      testsuite_flags=['--cppflags', '-mcpu=cortex-a57 -O0 -mllvm -global-isel -mllvm -global-isel-abort=0',
                                        '--threads=8', '--build-threads=8'],
----------------
rovka wrote:
> rengolin wrote:
> > @rovka is this still necessary? Isn't that the default for O0?
> > 
> > Also, mcpu changes. All or nothing.
> Nope, we should only need -O0 now. 
Will fix.


================
Comment at: buildbot/osuosl/master/config/builders.py:998
                         checkout_lld=False,
-                        extra_cmake_args=["-DCMAKE_C_FLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
-                                          "-DCMAKE_CXX_FLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
-                                          "-DCOMPILER_RT_TEST_COMPILER_CFLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
+                        extra_cmake_args=["-DCOMPILER_RT_TEST_COMPILER_CFLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
                                           "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
----------------
rengolin wrote:
> Are the others being set correctly? They weren't when I did this.
I don't follow:
"others" == ???
"They" == ???
Please elaborate :-) 


================
Comment at: buildbot/osuosl/master/config/builders.py:1290
          'factory': LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
             cmake_extra_opts={'LIBCXXABI_USE_LLVM_UNWINDER': 'ON',
                               'LLVM_PARALLEL_LINK_JOBS': '2'})},
----------------
rengolin wrote:
> why disabling marm/mthumb here?
This is a single-stage build, so CMAKE_C_FLAGS and CMAKE_CXX_FLAGS are passed only to host compiler.  AFAICT, they do not affect results of libcxx testsuites.


Repository:
  rL LLVM

https://reviews.llvm.org/D43117