[PATCH] D43071: [ELF] - Support DSECT, COPY, INFO, OVERLAY output sections attributes.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 07:21:45 PST 2018


>> +    if (consume("DSECT") || consume("COPY") || consume("INFO") ||
>> +        consume("OVERLAY")) {
>> +      expect(")");
>> +      Cmd->Dsect = true;
>
>Please use a more informative name (DontAlloc?) or at least add a
>comment to the definition.
>

I used Dsect because we usually call members in according
to documented name. And other names sound bit ambiguous probably.

Though if we can use "DontAlloc" or "NonAlloc" I would be happy.

George.


More information about the llvm-commits mailing list