[PATCH] D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 06:19:59 PST 2018


grimar added a comment.
Herald added a subscriber: arichardson.

In https://reviews.llvm.org/D43069#1002870, @ruiu wrote:

> This patch seems somewhat irrelevant to me because the issue you found is not actually related to the issue you described in the patch description. The issue you found is that we do not recognize "(INFO)" as a special tag, and that's different from ignoring symbols in dead sections.


I described how I found it. Add support for "INFO" and all its aliases is different patch (https://reviews.llvm.org/D43071), but still if you have undefined symbol in expression,
it should not be emited in output as undefined. And that is what this patch fixes. I'll remove part about "INFO" from description to avoid possible confusion.


https://reviews.llvm.org/D43069





More information about the llvm-commits mailing list