[PATCH] D43109: LTO: Include live bit in ThinLTO cache key.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc created this revision.
pcc added a reviewer: tejohnson.
Herald added subscribers: hiraditya, inglorion, mehdi_amini.

As of r323633, this bit started controlling whether symbol definitions
appear in object files, and is also became sensitive to the prevailing
bit, so it needs to be included in the key.


https://reviews.llvm.org/D43109

Files:
  llvm/lib/LTO/LTO.cpp
  llvm/test/LTO/Resolution/X86/cache-prevailing.ll


Index: llvm/test/LTO/Resolution/X86/cache-prevailing.ll
===================================================================
--- /dev/null
+++ llvm/test/LTO/Resolution/X86/cache-prevailing.ll
@@ -0,0 +1,18 @@
+; Tests whether the cache is sensitive to the prevailing bit.
+; RUN: rm -rf %t.cache
+; RUN: opt -module-hash -module-summary -o %t.bc %s
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo,p -r %t.bc,bar,px
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo, -r %t.bc,bar,px
+; RUN: ls %t.cache | count 2
+
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.11.0"
+
+ at foo = linkonce_odr constant i32 1, comdat
+$foo = comdat any
+
+define i32* @bar() {
+  ret i32* @foo
+}
Index: llvm/lib/LTO/LTO.cpp
===================================================================
--- llvm/lib/LTO/LTO.cpp
+++ llvm/lib/LTO/LTO.cpp
@@ -177,6 +177,7 @@
 
   auto AddUsedThings = [&](GlobalValueSummary *GS) {
     if (!GS) return;
+    AddUnsigned(GS->isLive());
     for (const ValueInfo &VI : GS->refs()) {
       AddUnsigned(VI.isDSOLocal());
       AddUsedCfiGlobal(VI.getGUID());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43109.133552.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180209/5bfaebdf/attachment.bin>