[PATCH] D43092: [DebugInfo] Prevent infinite recursion for malformed DWARF

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D43092#1002598, @dblaikie wrote:

> I'm guessing this is insufficient for catching indirect recursion (DIE A refers to DIE B and B back to A)?


That's true, unfortunately. Is it worth to convert this to a worklist and keep track of the already-seen DIEs?

> Ideally/the original version of this, I think was non-recursive and only specifically looked for certain attributes in order and then stopped. I'd sort of rather than, because it's more constrained.

The original `find()` still exists, so I'd expect this variant only to be used where the recursive property is needed.


https://reviews.llvm.org/D43092