[PATCH] D42994: Only throw -fPIC when building a shared library

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:49
             os.mkdir(newdir)
-        except OSError, e:
+        except OSError as e:
             if e.errno != os.errno.EEXIST:
----------------
zturner wrote:
> Weird, does that comma syntax even do anything or was that just a bug?
In python 2.5 or earlier it meant the same as "as" but "as" was not supported. Then for a while (until 3.x) both the comma and "as" meant the same thing and then since 3.x "as" is the only option allowed.


Repository:
  rL LLVM

https://reviews.llvm.org/D42994