[PATCH] D43027: [ThinLTO] Skip BlockAddresses while replacing uses in function import

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 13:33:34 PST 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/LowerTypeTests/Inputs/blockaddr-import.yaml:2-6
+TypeIdMap:
+  typeid1:
+    TTRes:
+      Kind:            AllOnes
+      SizeM1BitWidth:  7
----------------
I think you can remove this part.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:11
+
+define hidden void @l() local_unnamed_addr #0 !type !3 {
+entry:
----------------
Is this function still necessary?


https://reviews.llvm.org/D43027





More information about the llvm-commits mailing list