[PATCH] D43027: [ThinLTO] Skip BlockAddresses while replacing uses in function import

[Dmitry Mikulin via Phabricator via llvm-commits]

dmikulin marked an inline comment as done.
dmikulin added inline comments.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:1
+; RUN: opt -lowertypetests -lowertypetests-summary-action=import -lowertypetests-read-summary=%p/Inputs/blockaddr-import.yaml %s -o %t.o -O2
+
----------------
pcc wrote:
> I don't think you need `-O2` here.
I do not need the whole O2 pipeline, but the verifier relies on some analysis passes to set address-taken flags to assert. I changed it to -O1.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:29
+n:
+  %call = tail call i32 (i8*, ...) bitcast (i32 (...)* @o to i32 (i8*, ...)*)(i8* blockaddress(@m, %n)) #4
+  ret void
----------------
pcc wrote:
> Please use FileCheck to check that the blockaddress refers to the correct function.
Added a check to make sure blockaddress refers to the new function, m.cfi.


https://reviews.llvm.org/D43027