[PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 12:36:25 PST 2018


Looks good (but for the _Z case, make sure its length is at least 2)
On Thu, Feb 8, 2018 at 12:33 PM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> How about this?
>
>   if (name == nullptr)
>     return false;
>
>   return ( (name[0] == '?') || (name[0] == '_' && name[1] == 'Z') );
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43059
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180208/67d3a8f1/attachment.html>


More information about the llvm-commits mailing list