[PATCH] D43036: Use a stable topological sort instead of std::stable_sort in DIE *DwarfCompileUnit::createScopeChildrenDIE()

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 11:44:00 PST 2018


aprantl updated this revision to Diff 133463.
aprantl added a comment.

Added a bunch of interesting test cases, including the one with a global variable as dependency.
Note that none of these testcases trigger a crash in the old stable_sort code, since neither the order of the dbg.values nor the order in the list of local variables in the DIFunction has an effect on the order in which the locals appear in LexicalScopes.


https://reviews.llvm.org/D43036

Files:
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  test/DebugInfo/X86/vla-dependencies.ll
  test/DebugInfo/X86/vla-global.ll
  test/DebugInfo/X86/vla-multi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43036.133463.patch
Type: text/x-patch
Size: 15894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180208/902ac49e/attachment.bin>


More information about the llvm-commits mailing list