[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:561
+  if (CGOpts.EmitCodeView)
+    OutputFile = CGOpts.OutputFileName;
   TheCU = DBuilder.createCompileUnit(
----------------
You don't need to create a local copy of the string here. You could just use a ?: in the createCompileUnit invocation.


================
Comment at: llvm/test/Assembler/cu-outputfile.ll:1
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+; RUN: verify-uselistorder < %s
----------------
We usually do llvm-as < %s | llvm-dis - | llvm-as -| llvm-dis - | FileCheck.


================
Comment at: llvm/test/Bitcode/upgrade-cu-outputfile.ll:2
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+; RUN: verify-uselistorder < %s
+
----------------
There should be a .bc file created by an llvm-as from before this patch checked into the repository and that should be used as input.


https://reviews.llvm.org/D43002