[llvm] r324554 - AMDGPU: Fix incorrect reordering when inline asm defines LDS address

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 10:33:25 PST 2018



> On Feb 8, 2018, at 12:35, Michel Dänzer via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
> Hi Matt,
> 
> 
> On 2018-02-08 02:56 AM, Matt Arsenault via llvm-commits wrote:
>> Author: arsenm
>> Date: Wed Feb  7 17:56:14 2018
>> New Revision: 324554
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=324554&view=rev
>> Log:
>> AMDGPU: Fix incorrect reordering when inline asm defines LDS address
>> 
>> Defs of operands outside of the instruction's explicit defs need
>> to be checked.
> 
> This change broke a bunch of
> spec at arb_gpu_shader_int64@execution at built-in-functions piglit tests with
> radeonsi. I'm attaching good and bad code for one of them.
> 

I think this should be fixed by https://reviews.llvm.org/D42647

The problem seems to be an SCC use was separated from its def

-Matt


More information about the llvm-commits mailing list