[PATCH] D43038: [ELF] Don't sort non reorderable sections with --symbol-ordering-file

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 10:31:18 PST 2018


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added a comment.
>
> Can we exclude such sections from Order in `buildSectionOrder`. With that after landing https://reviews.llvm.org/D42475 we could
> warn/error on out such file entries too.

We should be able to avoid this sorting with the new callgraph based
sort.

I have the impression that doing the check inside sort itself might be
the best, but lets see.

LGTM to get the test passing and we can discuss any refactoring in the
context of the callgraph patch.

Cheers,
Rafael


More information about the llvm-commits mailing list