[PATCH] D43067: Implement equal_range for the DWARF v5 accelerator table

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:43
+
+    Entry() {}
+
----------------
= default


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:290-295
+    Entry(const Entry &RHS) : NameIdx(RHS.NameIdx), Abbr(RHS.Abbr) {
+      Values = RHS.Values;
+    }
+    Entry(Entry &&RHS) : NameIdx(RHS.NameIdx), Abbr(RHS.Abbr) {
+      Values = std::move(RHS.Values);
+    }
----------------
Could these be defaulted (maybe even implicitly defaulted)?


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:296
+    }
+    ~Entry() override;
+
----------------
Perhaps this should/could be implicit?


Repository:
  rL LLVM

https://reviews.llvm.org/D43067