[PATCH] D42740: Implement a case-folding version of DJB hash

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 09:53:50 PST 2018


joerg added inline comments.


================
Comment at: lib/Support/UnicodeCaseFold.cpp:26
+    return C + 32;
+  // 24 characters
+  if (C >= 0x0100 && C <= 0x012e)
----------------
Given that this should be applied to symbol names a lot, I would explicitly make the ASCII range fully covered to avoid all the other branches from getting triggered.


Repository:
  rL LLVM

https://reviews.llvm.org/D42740





More information about the llvm-commits mailing list