[llvm] r324511 - Revert "[DebugInfo] Improvements to representation of enumeration types (PR36168)"

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 01:39:05 PST 2018


I'm not sure if this is significant, but your next commit seems to
have fixed the tests
<http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/18892>

The same thing happened when you reverted the two commits. First
revert <http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/18902>
broke stuff, and the second fixed it
<http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/18904>.

So it seems to me that only the intermediate state between the two
commits is broken. I'm not sure if that means that everything is fine,
or if this exposes an unexpected (unwanted?) interaction between the
two commits, but if you need help making sense of what lldb tests are
doing, I am also available to help.

On 8 February 2018 at 07:58, Momchil Velikov via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Here's the first(?) failure link that I've got:
>
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/18891
>
> From: aprantl at apple.com <aprantl at apple.com> on behalf of Adrian Prantl <aprantl at apple.com>
> Sent: 07 February 2018 23:55:08
> To: Davide Italiano
> Cc: Momchil Velikov; llvm-commits; Vedant Kumar
> Subject: Re: [llvm] r324511 - Revert "[DebugInfo] Improvements to representation of enumeration types (PR36168)"
>
>
> Do you have a link to what bots/tests broke?
>
> -- adrian
>
>> On Feb 7, 2018, at 3:43 PM, Davide Italiano <davide at freebsd.org> wrote:
>>
>> On Wed, Feb 7, 2018 at 12:28 PM, Momchil Velikov via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: chill
>>> Date: Wed Feb  7 12:28:47 2018
>>> New Revision: 324511
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=324511&view=rev
>>> Log:
>>> Revert "[DebugInfo] Improvements to representation of enumeration types (PR36168)"
>>>
>>> Revert commit r324489, it broke LLDB tests.
>>>
>>
>> The fact that several of us spent so much time on the lldb bots that
>> now can catch debug info regressions makes me really happy.
>> Sorry you had to be the guinea pig for this, please let me know if
>> there's something I can do to help you on the debugger side of things.
>>
>> --
>> Davide
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list