[PATCH] D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API.

[Steven Wu via llvm-commits]

> On Feb 7, 2018, at 2:17 PM, Teresa Johnson <tejohnson at google.com> wrote:
> 
> 
> 
> On Tue, Feb 6, 2018 at 4:58 PM, Katya Romanova via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> kromanova added a comment.
> 
> Great! Teresa, please let me know if it's OK to commit or if you want me to change something in this patch.
> I got an OK from Steven Wu, Apple's ThinLTO/ld64 developer.
> 
> It's ok with me. Just to confirm, my understanding after reading through the thread is that currently ld64 will pass the value 0 to this by default, so with this change and the current ld64, pruning will be forced immediately. But Apple will change ld64 so in the future it would not do this. Is that correct?
> As long as Apple is happy, I'm fine with that.

I had a discussion with Duncan and we are ok with this. Just remember the next time when you use your custom libLTO on macOS during development, you might get cache pruning every time by default. However, the ld64 that supports thinLTO already has -prune_interval_lto which you can overwrite to get the behavior you want.

Steven


>  
> 
> 
> Repository:
>   rL LLVM
> 
> https://reviews.llvm.org/D42267 <https://reviews.llvm.org/D42267>
> 
> 
> 
> 
> 
> 
> -- 
> Teresa Johnson |	 Software Engineer |	 tejohnson at google.com <mailto:tejohnson at google.com> |	 408-460-2413

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/cf4eefa3/attachment.html>