[PATCH] D42963: Add initial ld.lld.1 man page

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 12:50:47 PST 2018


On Wed, Feb 7, 2018 at 12:45 PM, Ed Maste via Phabricator <
reviews at reviews.llvm.org> wrote:

> emaste added inline comments.
>
>
> ================
> Comment at: docs/ld.lld.1:4
> +.\"
> +.\" This man page documents only lld's ELF linking support, obtained
> originally
> +.\" from FreeBSD.
> ----------------
> krytarowski wrote:
> > emaste wrote:
> > > krytarowski wrote:
> > > > Can we put this to `.Sh HISTORY`?
> > > It seems excessive to create a `.Sh HISTORY` section containing only
> the history of the man page itself; this could perhaps be fleshed out in a
> subsequent commit with more history of lld and adoption in various projects?
> > I propose something like this:
> >
> > ```
> > .Sh HISTORY
> > This man page first appeared in
> > .Fx .
> > .Sh AUTHORS
> > .An Ed Maste Aq Mt ed at FreeBSD.org
> > ```
> >
> > A hidden comment has little added value.
> I'll come back to this for a future commit.


In the following commit, please also make a change for the change I just
submitted for --build-id. I added --build-id=fast which is a synonym for
--build-id (without an argument).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/3933a9d4/attachment.html>


More information about the llvm-commits mailing list