[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D43002#1000838, @aprantl wrote:

> This depends on whether this is just a nice-to-have feature for Windows or if it is important enough to warrant creating a new API function.


I can back out the api changes, it doesn't seem important enough to me until there is at least 1 active user of the c api who wants it.

> There is still the question on how this is supposed to behave in an LTO build? Do you want the name of the shared LTO.o file for all CUs, or do you want to preserve the names of the bitcode-.o files? If the former is the case, then it makes more sense to make this a property of the Module, otherwise it needs to be on the DICompileUnit.

I mentioned in another response but it might have been overlooked.  It needs to be the bitcode-.o files.



================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:567
       0 /* DWOid */, CGOpts.SplitDwarfInlining, CGOpts.DebugInfoForProfiling,
-      CGOpts.GnuPubnames);
+      CGOpts.GnuPubnames, remapDIPath(CGOpts.OutputFileName));
 }
----------------
aprantl wrote:
> Should this not be gated on the debuginfo kind being codeview?
Couldn't a non-CodeView processor just ignore this field if they aren't interested in it?  I can't think of a good reason to gate it at this high of a level.


https://reviews.llvm.org/D43002