[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In https://reviews.llvm.org/D43002#1000801, @dblaikie wrote:

> Adrian - what do you think about Reid's point regarding not changing the C API unless needed? I'm fairly OK with that, but not sure. Seems like it could be a surprising "gotcha" where someone thinks they're doing the right things to produce CodeView but they're missing this because the API isn't exposed/suggesting that usage.


This depends on whether this is just a nice-to-have feature for Windows or if it is important enough to warrant creating a new API function.

>> It would be more efficient to put, e.g., a NamedMDNode into the module so this information can be shared between the CUs.
> 
> I assume the string data itself is shared by the bitcode format? But I don't really know.

I think that is correct.

There is still the question on how this is supposed to behave in an LTO build? Do you want the name of the shared LTO.o file for all CUs, or do you want to preserve the names of the bitcode-.o files? If the former is the case, then it makes more sense to make this a property of the Module, otherwise it needs to be on the DICompileUnit.


https://reviews.llvm.org/D43002