[PATCH] D42585: [WebAssembly] Add symbol table to LLD, 2/2

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: test/wasm/alias.ll:64
 ; CHECK-NEXT:         Index:           0
-; CHECK-NEXT:       - Name:            __heap_base
-; CHECK-NEXT:         Kind:            GLOBAL
----------------
sbc100 wrote:
> As discussed on IRC lets keep these exported globals in the executable output (just like we do for functions, no need to export in the relocatable output).  Should make the diff smaller too I guess?
OK, I've done that.

We now export a "fake" global specifically for the __heap_base and __data_end symbols.

Why not for all data symbols? Because actually these are the only "fake" globals that we're currently exporting in non-relocatable output.

As a follow-up commit, we can certainly add a fake-global for all data symbols.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42585