[PATCH] D41955: [WebAssembly] Add symbol table to LLD, 1/2

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: test/wasm/init-fini.ll:153
 ; RELOC-NEXT:       - Priority:        101
-; RELOC-NEXT:         FunctionIndex:   0
+; RELOC-NEXT:         FunctionIndex:   2
 ; RELOC-NEXT:       - Priority:        101
----------------
sbc100 wrote:
> This should be called "Symbol:" now, right? (at last with 2/2)
Renamed to "Symbol:"


================
Comment at: test/wasm/many-functions.ll:22
 ; CHECK-NEXT:       - Type:            R_WEBASSEMBLY_MEMORY_ADDR_LEB
-; CHECK-NEXT:         Index:           0
+; CHECK-NEXT:         Index:           130
 ; CHECK-NEXT:         Offset:          0x00000008
----------------
sbc100 wrote:
> Ditto.
Hmm, I've left it as just "Index" for the time being. We could rename it in a later commit.

Relocations have a Type/Index/Addend, which is consistent for the different types, whereas if we change it to "Symbol" it would then have to be different for TYPE relocations, which seems uglier to me (initially).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41955