[PATCH] D43024: [test] Enable test category for inline tests.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 08:16:08 PST 2018


labath added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:307-308
                 "@add_test_categories can only be used to decorate a test method")
         if hasattr(func, "categories"):
             cat.extend(func.categories)
+        # For instance methods, the attribute must be set on the actual function.
----------------
These two lines look like they need to be fixed as well.


================
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:526
                 return None
-        
+
         header = os.path.join(
----------------
davide wrote:
> We should consider clang-formatting this file altogether.
The current (weird) formatting is the result of running `autopep8` as a part of the huge refactor some time ago...


Repository:
  rL LLVM

https://reviews.llvm.org/D43024





More information about the llvm-commits mailing list