[lld] r324467 - [ELF][MIPS] Ignore incorrect version definition index for _gp_disp symbol

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 02:52:39 PST 2018


Merged both in r324471.

On Wed, Feb 7, 2018 at 11:37 AM, Simon Atanasyan <simon at atanasyan.com> wrote:
> If it's not too late, r324467 and r324468 revisions should be merged
> into the release_60 branch.
>
> On Wed, Feb 7, 2018 at 1:02 PM, Simon Atanasyan via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: atanasyan
>> Date: Wed Feb  7 02:02:49 2018
>> New Revision: 324467
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=324467&view=rev
>> Log:
>> [ELF][MIPS] Ignore incorrect version definition index for _gp_disp symbol
>>
>> MIPS BFD linker puts _gp_disp symbol into DSO files and assigns zero
>> version definition index to it. This value means 'unversioned local
>> symbol' while _gp_disp is a section global symbol. We have to handle
>> this bug in the LLD because BFD linker is used for building MIPS
>> toolchain libraries.
>>
>> Differential revision: https://reviews.llvm.org/D42486
>>
>> Added:
>>     lld/trunk/test/ELF/Inputs/mips-gp-dips-corrupt-ver.s
>>     lld/trunk/test/ELF/Inputs/mips-gp-dips-corrupt-ver.so   (with props)
>>     lld/trunk/test/ELF/mips-gp-disp-ver.s
>> Modified:
>>     lld/trunk/ELF/InputFiles.cpp
>
> --
> Simon Atanasyan


More information about the llvm-commits mailing list