[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 20:37:46 PST 2018


rnk added a comment.

I'd back out the C API changes, but otherwise this makes sense to me. Let's check with @aprantl, though.



================
Comment at: llvm/include/llvm-c/DebugInfo.h:202-203
     LLVMDWARFEmissionKind Kind, unsigned DWOId, LLVMBool SplitDebugInlining,
-    LLVMBool DebugInfoForProfiling);
+    LLVMBool DebugInfoForProfiling, const char *OutputFile,
+    size_t OutputFileLen);
 
----------------
I'd suggest leaving this alone, we can add a LLVMDIBuilderCreateCompileUnit2 if any frontend using the C API ever cares about this.


https://reviews.llvm.org/D43002





More information about the llvm-commits mailing list