[PATCH] D42999: [TLS] use emulated TLS if the target supports only this mode

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 19:04:55 PST 2018


jyknight added a comment.

This doesn't seem like the right way to go.

First the easy things:
The llc tool is not intended to be a user-facing tool, so I don't think that justifies it on its own.
This breaks -fno-emulated-tls.

Then, LTO...
For sure, the way that flags get passed down into LTO currently is certainly a quite-irritating set of kludges. However, teaching the clang driver to pass the right flag through to the lto plugin seems entirely possible, and would seem to actually fix the issue more completely, also handling a user-specified -femulated-tls flag on non-android platforms.


https://reviews.llvm.org/D42999





More information about the llvm-commits mailing list