[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 17:43:38 PST 2018


pcc added a comment.

This needs more tests. In particular you should have:

1. More test coverage for serialization.
2. A test for the bitcode reader functionality. This should probably be in the form of a test that simulates a distributed build and shows that the correct resolution is passed to the backend. There are a few examples in `clang/test/CodeGen/thinlto-*` but they all use the legacy LTO API driver (`llvm-lto`) which is incompatible with ThinLTO+CFI, so you will probably need to have your test use `llvm-lto2` (with the `-thinlto-distributed-indexes` flag).


https://reviews.llvm.org/D42611





More information about the llvm-commits mailing list