[PATCH] D36311: [ThinLTO] Add GraphTraits for FunctionSummaries

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 11:42:13 PST 2018


tejohnson added a comment.

In https://reviews.llvm.org/D36311#990888, @tejohnson wrote:

> It looks like https://reviews.llvm.org/D36850 got accidentally merged into this version of the patch -make sure to remove that.


Hi Charles,

I was just chatting with Easwaran - he's using your patch and building on top of it for frequency propagation changes. Would you be able to address my last round of comments which are all minor and don't need a re-review, and commit this soon (say in the next week)? If not, let me know if you would like one of us to commit it (attributing it to you).  (Easwaran says don't worry about his comment regarding the NodeRef for this patch.)

Thanks!
Teresa


https://reviews.llvm.org/D36311





More information about the llvm-commits mailing list