[PATCH] D42880: [dsymutil] Upstream update feature.

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

Just a couple of nits.



================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2890
+
+  if (LLVM_UNLIKELY(Linker.Options.Update)) {
+    if (auto OptionalValue = Val.getAsUnsignedConstant())
----------------
`LLVM_UNLIKELY` ? Does this really matter?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:3235
+    if (LLVM_LIKELY(!Options.Update) &&
+        shouldSkipAttribute(AttrSpec, Die->getTag(), Info.InDebugMap,
                             Flags & TF_SkipPC, Flags & TF_InFunctionScope)) {
----------------
ditto.


https://reviews.llvm.org/D42880