[PATCH] D42946: Verify profile data confirms large loop trip counts.

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 05:01:01 PST 2018


bkramer added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:8356
+    if (ConstExits->getValue()->getZExtValue() <
+        std::numeric_limits<unsigned>::max()) {
+      ExpectedTC =
----------------
I'd prefer something like ConstExits->getValue()->getActiveBits() <= 32. getZExtValue is not safe for values larger than 64 bits, which are rare but can happen in theory.


Repository:
  rL LLVM

https://reviews.llvm.org/D42946





More information about the llvm-commits mailing list