[llvm] r323297 - Don't assume a null GV is local for ELF and MachO.

[Brooks Moses via llvm-commits]

On Mon, Feb 5, 2018 at 8:01 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:
> > From llvm's point of view I would say that it is all missing features in
> > grubs partial implementation of the ABI.
> >
> > I am happy helping implement the missing bits in grub, but I don't think
> > we should avoid this change in llvm.
>
> The attached file should implement the missing relocation on i386. How
> do I test it?
>

Thanks for the quickly-implemented fix!  Honestly, I'm not sure how to
fully test that this boots, but one of our grub developers has offered to
test things for me if needed, so I'll give this a quick try tomorrow
morning to make sure it builds in our build system, and then hand it off to
him for testing.  Hopefully we can let you know tomorrow afternoon if this
works and get you unblocked on re-committing the patch.

If this is indeed the extent of the change required for grub, I agree with
your analysis that this shouldn't be a blocker.

- Brooks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180205/07e23e96/attachment.html>