[PATCH] D42520: Implement __attribute__((import_module("foo")))

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 16:41:54 PST 2018


sunfish updated this revision to Diff 132910.
sunfish removed a reviewer: aaron.ballman.
sunfish added a comment.

- Go back to using "env" for now, so that this is independent of the symbol-table changes and avoids bike-shedding discussions for now.
- Split the clang changes out into a separate patch, which I'll post separately.

I believe this addresses all the comments so far on the LLVM side; I'll address the clang comments on the clang patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D42520

Files:
  include/llvm/MC/MCSymbolWasm.h
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h
  lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  test/CodeGen/WebAssembly/import-module.ll
  test/MC/WebAssembly/external-func-address.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42520.132910.patch
Type: text/x-patch
Size: 6732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180206/54a0b016/attachment.bin>


More information about the llvm-commits mailing list