[llvm] r324291 - LTO: Also include dso-local bit for calls in ThinLTO cache key.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 15:46:33 PST 2018


Author: pcc
Date: Mon Feb  5 15:46:32 2018
New Revision: 324291

URL: http://llvm.org/viewvc/llvm-project?rev=324291&view=rev
Log:
LTO: Also include dso-local bit for calls in ThinLTO cache key.

Differential Revision: https://reviews.llvm.org/D42934

Added:
    llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll
Modified:
    llvm/trunk/lib/LTO/LTO.cpp

Modified: llvm/trunk/lib/LTO/LTO.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTO.cpp?rev=324291&r1=324290&r2=324291&view=diff
==============================================================================
--- llvm/trunk/lib/LTO/LTO.cpp (original)
+++ llvm/trunk/lib/LTO/LTO.cpp Mon Feb  5 15:46:32 2018
@@ -192,8 +192,10 @@ static void computeCacheKey(
         UsedTypeIds.insert(TT.VFunc.GUID);
       for (auto &TT : FS->type_checked_load_const_vcalls())
         UsedTypeIds.insert(TT.VFunc.GUID);
-      for (auto &ET : FS->calls())
+      for (auto &ET : FS->calls()) {
+        AddUnsigned(ET.first.isDSOLocal());
         AddUsedCfiGlobal(ET.first.getGUID());
+      }
     }
   };
 

Added: llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll?rev=324291&view=auto
==============================================================================
--- llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll (added)
+++ llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll Mon Feb  5 15:46:32 2018
@@ -0,0 +1,23 @@
+; Tests whether the cache is sensitive to the dso-local bit on called
+; functions.
+; RUN: rm -rf %t.cache
+; RUN: opt -module-hash -module-summary -o %t.bc %s
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo,px \
+; RUN:   -r %t.bc,bar,px
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo,plx \
+; RUN:   -r %t.bc,bar,px
+; RUN: ls %t.cache | count 2
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define weak void @foo() {
+  ret void
+}
+
+define weak void @bar() {
+  call void @foo()
+  ret void
+}




More information about the llvm-commits mailing list